Changes to allow a migration of DRF tokens (#220 and #215)#295
Changes to allow a migration of DRF tokens (#220 and #215)#295gawry wants to merge 1 commit intojazzband:developfrom
Conversation
|
@gawry Thanks for the contribution! 😁 After reviewing your changes, I don't think the best place for this operation is a migration. The changes explicitly assume that people are using DRF's That said, there's some useful content in this PR that can become a nice piece of documentation guiding new users on how to perform the token migration on their applications. Are you interested in changing this PR to a documentation improvement? Edit: I'll try to find some time to reply to the issues you linked in the next few weeks. |
|
Hello @giovannicimolin, Thank you for taking the time to review my PR. I understand the concern about keeping the library agnostic to external libraries. The intention behind my changes was to ensure that the operation would only be executed when the user is leveraging DRF's authtoken model. If they aren't using it, the migration would simply be a no-op and wouldn't have any impact. By integrating this feature, we can provide a seamless experience for those who are using the authtoken model, without affecting those who aren't. The design has been crafted with the very purpose of ensuring that the library remains flexible and agnostic. However, if you still believe that this shouldn't be part of the core migration, I'm more than happy to pivot this PR into something else. Perhaps a documentation piece or a Looking forward to your feedback. Best, |
No description provided.