Mark TaggableManager add/set/remove/clear with alters_data - #954
Open
gyanu2507 wants to merge 1 commit into
Open
Mark TaggableManager add/set/remove/clear with alters_data#954gyanu2507 wants to merge 1 commit into
gyanu2507 wants to merge 1 commit into
Conversation
add/set/remove/clear write to the database. Without the flag, Django templates can invoke them during rendering.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #954 +/- ##
==========================================
+ Coverage 89.44% 89.49% +0.04%
==========================================
Files 11 11
Lines 862 866 +4
Branches 119 119
==========================================
+ Hits 771 775 +4
Misses 69 69
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #953.
Django related managers set
alters_data = Trueon methods that write, so templates won't call them._TaggableManager.add/set/remove/clearwere missing that, so a template lookup that landed on one of them could actually mutate tags.