Add a registry to dynamically (un)register auth methods #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudep
force-pushed
the
method_registry
branch
from
5260342 to
7fe01f3
Compare
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 96.64% 96.72% +0.07%
==========================================
Files 39 43 +4
Lines 1641 1739 +98
Branches 114 126 +12
==========================================
+ Hits 1586 1682 +96
- Misses 34 36 +2
Partials 21 21
Continue to review full report at Codecov.
|
Collaborator
|
I've not had a chance to do a proper review, but how does this compare to #280 ? |
Contributor
Author
|
Crap, didn't see that one. However, I'm sure we can go somewhere by uniting ideas. What I called |
Contributor
Author
|
This is obsolete now we have a plugin architecture in place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tentative patch to add some plugin architecture to allow for modular auth method implementations, following comments on PR #215. It's rather minimal and definitely not totally modular yet, but at least I have a proof of concept patch on my local system to add the U2F functionality (which I hope to integrate to this package).
I'm totally open to improve it following your comments.