Merged
Conversation
ef2e18b to
c305129
Compare
Contributor
Author
|
I see, that now it doesn't count with non-class based views. I must fix that. |
Contributor
Author
|
I added fix for non-class based views with test. |
Contributor
|
Hi @PetrDlouhy, could you please fix the flake8 failure? |
7b245ce to
2d1298b
Compare
Regression in 4bd592c.
2d1298b to
988e2ec
Compare
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
==========================================
- Coverage 95.67% 95.66% -0.02%
==========================================
Files 65 65
Lines 2938 2952 +14
Branches 329 331 +2
==========================================
+ Hits 2811 2824 +13
Misses 103 103
- Partials 24 25 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix regression introduced in #500.
Description
All the changes of
test_view_login.pywere wrong and they are reverted.We are now detecting if OTPRequiredMixin is used for
nextURL and only then we redirect to OTP setup page.The newly introduced test in OTPRequiredMixinTest is not changed and passes.
Motivation and Context
Fix regression described in #499
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: