Fix support for chaining the next parameter into the setup view.#622
Open
cjsoftuk wants to merge 1 commit intojazzband:masterfrom
Open
Fix support for chaining the next parameter into the setup view.#622cjsoftuk wants to merge 1 commit intojazzband:masterfrom
cjsoftuk wants to merge 1 commit intojazzband:masterfrom
Conversation
moggers87
requested changes
Feb 19, 2025
Collaborator
moggers87
left a comment
There was a problem hiding this comment.
Tests required and remove the session logic from SetupCompleteView please
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This branch provides a potential fix for issue #621
Motivation and Context
This solves the issue of the next parameter not being passed across.
How Has This Been Tested?
I have tested this in the application I was having the issue in, and from a user view point it seems to do exactly what I expect.
I have not yet built any specific tests for this functionality.
Types of changes
Checklist:
I welcome feedback on the proposed change, and understand that I probably need to build tests for it before anyone is prepared to merge it.