Added some guidance on how to build custom templates to implementing.rst#696
Added some guidance on how to build custom templates to implementing.rst#696Magnie wants to merge 3 commits intojazzband:masterfrom
Conversation
While trying to get WebAuthn to work, I couldn't figure out why the input field was readonly and had to dig into the original pull request to figure out I was missing JS. This just clarifies what is needed in custom templates to maintain functionality.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #696 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 78 78
Lines 3354 3354
Branches 377 377
=======================================
Hits 3204 3204
Misses 119 119
Partials 31 31 ☔ View full report in Codecov by Sentry. |
Includes more generic wording and improved formatting Co-authored-by: Sergei Maertens <sergei-maertens@users.noreply.github.com>
|
@sergei-maertens Thanks for your suggestions. I've committed them. Though with your changes I noticed the formatting looks a little weird in the preview. Is that intentional? I'm not used to the Edit: Ah, never mind. Previewing/testing suggested changes doesn't work super well. I've fixed the formatting for real this time. |
Description
While trying to get WebAuthn to work, I couldn't figure out why the input field was readonly and had to dig into the original pull request to figure out I was missing JS. This just clarifies what is needed in custom templates to maintain functionality.
Motivation and Context
Documentation is lacking any information on how to build the custom templates. The only information available is in the original template:
Provide a template named <code>two_factor/_base.html</code> to style this page and remove this message.How Has This Been Tested?
Just used the
Previewoption when editing the documentation. Otherwise, no functional changes have been made.Screenshots (if appropriate):
N/A
Types of changes
Checklist: