Skip to content

Conversation

@moggers87
Copy link
Collaborator

Python 3.8 ended support back in October and Python 3.13 is supported by Django 5.1

Description

  • Removed Python 3.8 from tox, Github actions, etc.
  • Added Python 3.13 to tox, Github actions, etc.
  • Bumped up Selenium version installed for testing
  • Stop testing Python 3.10 and 3.11 against Django main

Motivation and Context

How Has This Been Tested?

Ran tox locally and all tests passed

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

We no longer support Python 3.8 so we can use the latest Selenium
without issue
@moggers87
Copy link
Collaborator Author

I think I'm going to hold off on this PR until Django 5.2 is released. Tests pass when run against Django main so I don't foresee any changes other than adding it to the test matrix once released.

strategy:
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also saw some projects recently limiting the tests to the lower and higher Python versions, which should not make a big difference in test accuracy, but consumes less resources.

Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@claudep
Copy link
Contributor

claudep commented Apr 3, 2025

Feel free to merge this, thanks 👍

@moggers87 moggers87 marked this pull request as ready for review April 3, 2025 08:46
@moggers87 moggers87 merged commit a839818 into jazzband:master Apr 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants