Skip to content

Conversation

@hirotasoshu
Copy link
Contributor

Resolves #753

Description

This PR upgrades issue templates (current issue template is not being used by github). I also split issue templates to bug_report and feature_request with adding a little "sugar", i.e. auto-labeling and title template (the same way I did in django-axes)

Motivation and Context

I think motivation is pretty clear:)

How Has This Been Tested?

You can look how it works at django-axes repo

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hirotasoshu hirotasoshu requested a review from moggers87 April 17, 2025 13:21
remove comments about feature request -- feature requests should use `feature_request` template
Copy link
Collaborator

@moggers87 moggers87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to do this. Other than the label on the feature request template I think this is good to be merged.

@hirotasoshu hirotasoshu requested a review from moggers87 April 18, 2025 07:59
Copy link
Collaborator

@moggers87 moggers87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@moggers87 moggers87 merged commit 227bb96 into jazzband:master Apr 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Github no longer uses issue template

2 participants