Update installation doc; phonenumber required.#764
Open
William-Blackie wants to merge 1 commit intojazzband:masterfrom
Open
Update installation doc; phonenumber required.#764William-Blackie wants to merge 1 commit intojazzband:masterfrom
William-Blackie wants to merge 1 commit intojazzband:masterfrom
Conversation
Contributor
|
In fact, I'd rather push for finishing the work on PR #654 to finally be able to make phonenumber packages really optional. |
moggers87
reviewed
May 31, 2025
| 'otp_yubikey', # <- for yubikey capability. | ||
| 'two_factor', | ||
| 'two_factor.plugins.phonenumber', # <- for phone number capability. | ||
| 'two_factor.plugins.phonenumber', # <- Required, even if phone is not used. |
Collaborator
There was a problem hiding this comment.
I don't think this is true - I currently use two_factor without the phone number plugin listed in my INSTALLED_APPS: https://codeberg.org/Inboxen/Inboxen/src/commit/e441dd4aece7028b32307b1e7980ff5301a37814/inboxen/settings.py#L248
Collaborator
There was a problem hiding this comment.
I do have to install the phonenumbers and django-phonenumber-field packages which is what needs to be solved to close #469 if i understand things correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
love the package. I stumbled across an issue that it's clear from looking through the issues; (#469) that the phonenumberfield/configuration is required, can we update the documentation to reflect this? This cost me a number of hours trying to dig this issue out.
Description
Simple one line change to reflect that the phonenumber package is required.
Motivation and Context
It makes it clear that even if you do not use the phone number field, it is required.
How Has This Been Tested?
N/a.
Screenshots (if appropriate):
N/a.
Types of changes
Checklist: