Conversation
WhyNotHugo
requested changes
Mar 15, 2026
Contributor
Author
|
Hold off on merging this just yet, looking into an issue with |
Member
|
Ack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests were not working on my machine, so I fixed them.
I also updated the Tox config to only test versions of Python and Django that were still supported by upstream. Except for Django 4.2, since support for that ends in about only six weeks.
Lastly, instead of using a Perl script wrapped in a Docker image to generate the MMDB files for tests, I converted that to a Python script.
Motivation and Context
Tests now run (again), and our test process is simplified and dependencies minified.
How Has This Been Tested?
All tests run and pass.
Types of changes
Checklist: