feat: add option to enable/disable verify jti claim (default: enabled) #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew-Chen-Wang
requested changes
Jul 1, 2020
rest_framework_simplejwt/settings.py
Outdated
| @@ -14,6 +14,7 @@ | |||
| 'REFRESH_TOKEN_LIFETIME': timedelta(days=1), | |||
| 'ROTATE_REFRESH_TOKENS': False, | |||
| 'BLACKLIST_AFTER_ROTATION': True, | |||
| 'JTI_CLAIM_IS_MENDATORY': True, | |||
There was a problem hiding this comment.
Mandatory, not mendatory
There was a problem hiding this comment.
It was necessary for my application as we have to authenticate users with a JWT token without a JTI claim. We don't own the JWT creation which is done by another external service and JWT comes without JTI claim.
We use django-rest-framework-simplejwt only to verify token with the private key (this is the important part of the authentication for me, not the jti ) and receive an authenticated user.
We don't use the token creation part.
A more precise name for the option would be:
ALLOW_THIRD_PARTY_TOKEN_WITHOUT_JTI_CLAIM : True
tizbecool
force-pushed
the
jti-claim-is-optional
branch
from
05d01f3 to
e8d38ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to deal with token without id and created from a third party so I had to make the JTI claim optional as it is in the RFC (https://tools.ietf.org/html/rfc7519#section-4.1.7).
I made this quick and it's may be not the most elegant or expected implementation :)