Delete OutstandingToken via django-admin #237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
==== 124 passed in 1.73s ==== Doesn't effect unit tests. I'll test is out locally today or tomorrow. |
| @@ -3,7 +3,7 @@ | |||
|
|
|||
|
|
|||
| class OutstandingToken(models.Model): | |||
| user = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.CASCADE, null=True, blank=True) | |||
| user = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.SET_NULL, null=True, blank=True) | |||
There was a problem hiding this comment.
If this happens then you should change the SET_NULL in the migrations (deliberately without creating a new file).
There was a problem hiding this comment.
Also, I'm not entirely sure if you should change it to be SET_NULL...
| @@ -33,7 +35,9 @@ def get_readonly_fields(self, *args, **kwargs): | |||
| def has_add_permission(self, *args, **kwargs): | |||
| return False | |||
|
|
|||
| def has_delete_permission(self, *args, **kwargs): | |||
| def has_delete_permission(self, request, *args, **kwargs): | |||
| if request.user.is_superuser: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On user deletion, set OutstandingToken.user to NULL and blacklist user tokens
Fix for #201
I still need to figure out how to run unit tests, but if anyone else wants to look this over and give me feedback, I'd appreciate it.