Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description of how to update custom claims on refresh to README #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

henrywoody
Copy link

Adds a description of how to update custom claims on token refresh requests. This expands the section of the README called "Customizing token claims" and the added description's structure mirrors that of the existing "Customizing token claims" section.

This is helpful to include because it is not uncommon for token data to become outdated quicker than refresh tokens expire on average. Issue 33 was a question about this sort of behavior and this added description borrows from the response to issue 33 by davesque. Similarly, issue 59 (about revoking refresh tokens if the user's password is changed) would benefit from this description.

@henrywoody
Copy link
Author

I think the test failure is coming from a dependency since I only changed the README.

Error Message:

django.db.utils.NotSupportedError: SQLite schema editor cannot be used while foreign key
constraint checks are enabled. Make sure to disable them before entering a transaction.atomic()
context because SQLite3 does not support disabling them in the middle of a multi-statement
transaction.

ajhodges added a commit to ShipChain/django-rest-framework-simplejwt that referenced this pull request Jan 15, 2019
@henrywoody henrywoody force-pushed the update-readme-for-updating-claims-on-refresh branch from c2c7b75 to 90bb37e Compare July 10, 2019 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant