Merged
Conversation
50-Course
reviewed
Jan 7, 2025
Member
50-Course
left a comment
50-Course
left a comment
There was a problem hiding this comment.
there only appears to be one failing check here:
Run actions/setup-python@v2
Version 3.13 was not found in the local cache
I believe we have to bump it to v4 or v5, which are compatible with python 3.13 (and are contained in cache)
actions/setup-python@v5
Member
Author
|
thx for the review; updated. Also found out the i18n action was disabled 💀 Just re enabled it to work on master |
Member
|
ah, dependabot already caught it here, we're good 👍🏼 #849 |
50-Course
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.