-
Notifications
You must be signed in to change notification settings - Fork 693
Update .gitignore to exclude unnecessary files #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Added *.pid and *.DS_Store to ignore process ID files and macOS system files.
for more information, see https://pre-commit.ci
# macOS system files | ||
*.DS_Store | ||
|
||
# Process ID files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.DS_Store means Desktop Services Store. It's a hidden file that macOS creates in folders to save things like icon position, window size, and folder layout.
We add *.DS_Store to .gitignore because:
- It's not part of the code.
- It can be accidentally committed by macOS users.
- It adds unnecessary files to the project.
- It's not useful for people using Windows or Linux.
- macOS creates this file automatically when someone opens a folder, so it might get added without them noticing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.pid files store the Process ID of a running service or application (like a web server or background worker like celery). These files are temporary, system-specific, and should not be tracked in version control.
✅ Ignoring both helps keep the repository clean and free from unnecessary or machine-specific files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant specifically PID. Where in this repository are we generating PID files? Seems unnecessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, and I agree that adding *.pid is unnecessary. However, I wanted to point out that celerybeat.pid is already included in the .gitignore file under the Celery stuff section.
Please check this PR @Andrew-Chen-Wang |
please stop pinging me as I am busy |
Just noting that this PR and my other open ones have been pending for a few weeks. |
Please check this PR @davesque |
📌 Update .gitignore to Exclude Unnecessary Files
Description
This PR updates the
.gitignore
file to improve file exclusions and prevent unnecessary files from being tracked.🔄 Changes
*.pid
and*.DS_Store
to ignore process ID files and macOS system files.Let me know if any adjustments are needed! 👍