feat: improve TokenBlacklistSerializer return values#901
Open
juanbailon wants to merge 2 commits intojazzband:masterfrom
Open
feat: improve TokenBlacklistSerializer return values#901juanbailon wants to merge 2 commits intojazzband:masterfrom
juanbailon wants to merge 2 commits intojazzband:masterfrom
Conversation
- Raise exception when token_blacklist app is not enabled or available.
- Return a success message ('Token blacklisted') when a token is successfully blacklisted.
- Update tests to reflect the new return behavior.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise TokenBlacklistNotConfigured exception when token_blacklist app is not installed, returning an error message and a 501 Not Implemented status code.
Return a success message ('Token blacklisted') when a token is successfully blacklisted.
Update tests to reflect the new return behavior.
Tackles Issue #742
Tests name changes
In test_views.py
In test_serializers.py