Fix: Add mypy to pre-commit #924
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/test.yml
Outdated
| tox -v | ||
| - name: Run mypy | ||
| run: | | ||
| pip install mypy==1.17.1 |
There was a problem hiding this comment.
why install a specific mypy version?
|
Before we can merge this, we need to fix all of the mypy issues in our codebase. At the moment, when i run it, i get the following results: |
Andrew-Chen-Wang
requested changes
Sep 21, 2025
| - name: Run mypy | ||
| run: | | ||
| pip install mypy | ||
| mypy rest_framework_simplejwt |
There was a problem hiding this comment.
This should also be checking the tests folder
| rev: v1.17.1 | ||
| hooks: | ||
| - id: mypy | ||
| args: ["rest_framework_simplejwt"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #896