Skip to content

Fix compiling input setup file in nested folders - #1324

Merged
atugushev merged 2 commits into
jazzband:masterfrom
peymanslh:fix_nested_basename
Feb 24, 2021
Merged

Fix compiling input setup file in nested folders#1324
atugushev merged 2 commits into
jazzband:masterfrom
peymanslh:fix_nested_basename

Conversation

@peymanslh

@peymanslh peymanslh commented Feb 14, 2021 •
edited by atugushev
Loading

Copy link
Copy Markdown
Member

Closes #1312

Changelog-friendly one-liner: Fix compiling input setup.py file in nested folders

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@peymanslh
peymanslh requested a review from atugushev February 14, 2021 18:56
@codecov

codecov Bot commented Feb 14, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1324 (a92734a) into master (2be5cbf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1324   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files          33       33           
  Lines        2921     2928    +7     
  Branches      318      318           
=======================================
+ Hits         2910     2917    +7     
  Misses          5        5           
  Partials        6        6
Impacted Files Coverage Δ
piptools/scripts/compile.py 100.00% <100.00%> (ø)
tests/test_cli_compile.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be5cbf...a92734a. Read the comment docs.

atugushev
atugushev reviewed Feb 15, 2021
View reviewed changes

@atugushev atugushev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peymanslh thanks! Could you add a test for this particular case?

@peymanslh
peymanslh requested a review from atugushev February 20, 2021 11:19
atugushev
atugushev reviewed Feb 23, 2021
View reviewed changes

@atugushev atugushev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test! A few comments below:

Comment thread tests/test_cli_compile.py Outdated
Comment thread tests/test_cli_compile.py Outdated
Comment thread piptools/scripts/compile.py Outdated
@peymanslh
Fix compiling input setup file in nested folders
2b1dcd6 
Add unit test

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Fix some issues

Co-authored-by: Albert Tugushev <albert@tugushev.ru>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
atugushev
atugushev approved these changes Feb 24, 2021
View reviewed changes

@atugushev atugushev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏼

@atugushev

atugushev commented Feb 24, 2021

Copy link
Copy Markdown
Member

@AndydeCleyre it's okay if we merge this before #1329? What do you think?

@atugushev atugushev added the setuptools Related to compiling requirements with `setuptools` build backend label Feb 24, 2021
atugushev
atugushev reviewed Feb 24, 2021
View reviewed changes
Comment thread tests/test_cli_compile.py Outdated
@AndydeCleyre

AndydeCleyre commented Feb 24, 2021

Copy link
Copy Markdown
Contributor

@AndydeCleyre it's okay if we merge this before #1329? What do you think?

Sure, I still need to add more tests, I'll rebase later and iron any wrinkles out.

@atugushev atugushev added this to the 6.0.0 milestone Feb 24, 2021
@atugushev
atugushev merged commit 1931e21 into jazzband:master Feb 24, 2021
@atugushev

atugushev commented Feb 24, 2021

Copy link
Copy Markdown
Member

Wonderfull! Thanks, @peymanslh!

@peymanslh

peymanslh commented Feb 24, 2021

Copy link
Copy Markdown
Member Author

Wonderfull! Thanks, @peymanslh!

Thanks for your review and suggestion!

This was referenced Mar 14, 2021
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 15, 2021
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atugushev atugushev atugushev approved these changes

Assignees

No one assigned

Labels

setuptools Related to compiling requirements with `setuptools` build backend

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

Compiling setup.py in a nested folder produces setup.txt

3 participants

@peymanslh @atugushev @AndydeCleyre