Introduce --add-package/-A pip-compile flag#1742
Draft
ntjess wants to merge 1 commit intojazzband:mainfrom
Draft
Introduce --add-package/-A pip-compile flag#1742ntjess wants to merge 1 commit intojazzband:mainfrom
--add-package/-A pip-compile flag#1742ntjess wants to merge 1 commit intojazzband:mainfrom
Conversation
ntjess
commented
Dec 19, 2022
| upgrade_install_reqs = { | ||
| key_from_ireq(install_req): install_req for install_req in upgrade_reqs_gen | ||
| } | ||
| # Similar procedure for --add-package/-E but the key is not needed since |
Author
There was a problem hiding this comment.
-E in this comment should be -A.
chrysle
added
feature
Contributor
|
You need to rebase your pull request on current HEAD. The behavior of resolving packages to upgrade has been adjusted in #1578 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1730 for context. This new flag allows specifying packages on the command line instead of forcing them to come from a requirements file. May offer improved usage compared to piping from stdin as described in the linked issue.
Let me know your thoughts 🙂
(I'm waiting to add tests until after I hear whether the implementation is favorable compared to e.g. using a different flag name, supplementing
pip-args, etc.)Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.