Allow build deps as long as at least one setup file is in sources list.#2077
Open
Walter-Gates-Bose wants to merge 7 commits intojazzband:mainfrom
Open
Conversation
Passing ``--build-deps-for`` or ``--all-build-deps`` should not emit an error as long as at least one file in the sources list is a setup file.
for more information, see https://pre-commit.ci
webknjaz
requested changes
Apr 15, 2024
Member
webknjaz
left a comment
webknjaz
left a comment
There was a problem hiding this comment.
I'm 👎 on this one since it opens up a can of worms (#2076 (comment)) — the implication of such an interface would be that the build deps of everything listed in the requirement inputs would be collected which is simply untrue.
Member
|
cc @apljungquist ^ |
…ps://github.com/Walter-Gates-Bose/pip-tools into allow-all-build-deps-when-multiple-source-files
for more information, see https://pre-commit.ci
…ps://github.com/Walter-Gates-Bose/pip-tools into allow-all-build-deps-when-multiple-source-files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves 2076.
Passing
--build-deps-foror--all-build-depsshould not emit an error as long as at least one file in the sources list is a setup file.Using
pip-compile --all-build-deps requirments.in pyproject.tomlgives the error--build-deps-for and --all-build-deps can be used only with the setup.py, setup.cfg and pyproject.toml specs..According to the help, using multiple source files is valid, so any options that apply to at least one source file should be allowed as long as that option does not cause a conflict.
Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.