Add a --parallel-live to tox invocations in CI - #2190
Conversation
f4515e5 to
ea9059b
Compare
webknjaz
changed the title
-p auto to tox invocations in CI--parallel-live to tox invocations in CI
ea9059b to
f10da6f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a regression in tox by adding the “--parallel-live” flag to various tox invocations within the CI configuration. Key changes include:
- Adding “--parallel-live” to the “Prepare test environment” steps.
- Updating tox invocations in both the installation and testing steps.
- Adding explanatory comments referencing the upstream tox issue.
| - name: Install test dependencies | ||
| run: python -m pip install -U tox virtualenv | ||
| - name: Prepare test environment | ||
| # NOTE: `--parallel-live` is a workaround for the regression in |
There was a problem hiding this comment.
[nitpick] The workaround comment is repeated across multiple steps. Consider defining a YAML anchor or a shared comment block to improve maintainability and reduce duplication if future updates are needed.
There was a problem hiding this comment.
Did we opt in to these? I find the copilot review -- in this case at least -- useless and distracting. I'll open an issue for us to discuss repo settings for this.
There was a problem hiding this comment.
@sirosen yes, I added it as a reviewer in this PR to see what it does. Sometimes LLMs surface interesting things, sometimes they hallucinate. But in general, it's interesting to see what it outputs and judge later.
sirosen
left a comment
sirosen
left a comment
There was a problem hiding this comment.
I'm also wondering if we should be using tox run as our invocation, but we can consider that later. I think this is a good fix as it is.
This is a workaround for the upstream tox regression [[1]] when the previous recommendation of setting the `TOX_PARALLEL_NO_SPINNER=1` env var conflicts with it auto-enabling parallelism. [1]: tox-dev/tox#3193
f10da6f to
35d7e70
Compare
This is a workaround for the upstream tox regression [1] when the previous recommendation of setting the
TOX_PARALLEL_NO_SPINNER=1env var conflicts with it auto-enabling parallelism.Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.