Remove the 'prettier' pre-commit hook - #2196
Merged
Merged
Conversation
Rationale: - the mirror repo is archived - the last human-driven maintenance involving this hook was in late 2022 (2.5 years ago at time of writing) - the hook itself behaves in an unstable way, repeatedly reformatting the same bits of markdown content (see: jazzband#2194) - the hook was introduced to format MD, TOML, JSON, and YAML content, and better solutions exist for each of these formats - JSON: we can use the hook from pre-commit-hooks - TOML: we only have pyproject.toml, we can use the tox-dev hook - MD: it is better to do nothing; offers questionable value - YAML: we could use `ruamel.yaml.cmd`; offers questionable value
sirosen
force-pushed
the
remove-prettier-hook
branch
from
June 26, 2025 20:53
e87e03e to
89fe586
Compare
webknjaz
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale:
2022 (2.5 years ago at time of writing)
the same bits of markdown content
(see: [pre-commit.ci] pre-commit autoupdate #2194)
and better solutions exist for each of these formats
ruamel.yaml.cmd; offers questionable valueContributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.