Skip to content

Remove the 'prettier' pre-commit hook - #2196

Merged
webknjaz merged 2 commits into
jazzband:mainfrom
sirosen:remove-prettier-hook
Jun 26, 2025
Merged

Remove the 'prettier' pre-commit hook#2196
webknjaz merged 2 commits into
jazzband:mainfrom
sirosen:remove-prettier-hook

Conversation

@sirosen

@sirosen sirosen commented Jun 26, 2025

Copy link
Copy Markdown
Member

Rationale:

  • the mirror repo is archived
  • the last human-driven maintenance involving this hook was in late
    2022 (2.5 years ago at time of writing)
  • the hook itself behaves in an unstable way, repeatedly reformatting
    the same bits of markdown content
    (see: [pre-commit.ci] pre-commit autoupdate #2194)
  • the hook was introduced to format MD, TOML, JSON, and YAML content,
    and better solutions exist for each of these formats
    • JSON: we can use the hook from pre-commit-hooks
    • TOML: we only have pyproject.toml, we can use the tox-dev hook
    • MD: it is better to do nothing; offers questionable value
    • YAML: we could use ruamel.yaml.cmd; offers questionable value
Contributor checklist
  • Included tests for the changes.
  • PR title is short, clear, and ready to be included in the user-facing changelog.
Maintainer checklist
  • Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@sirosen sirosen added maintenance Related to maintenance processes skip-changelog Avoid listing in changelog labels Jun 26, 2025
sirosen added 2 commits June 26, 2025 15:53
Rationale:

- the mirror repo is archived
- the last human-driven maintenance involving this hook was in late
  2022 (2.5 years ago at time of writing)
- the hook itself behaves in an unstable way, repeatedly reformatting
  the same bits of markdown content
  (see: jazzband#2194)
- the hook was introduced to format MD, TOML, JSON, and YAML content,
  and better solutions exist for each of these formats
  - JSON: we can use the hook from pre-commit-hooks
  - TOML: we only have pyproject.toml, we can use the tox-dev hook
  - MD: it is better to do nothing; offers questionable value
  - YAML: we could use `ruamel.yaml.cmd`; offers questionable value
@sirosen
sirosen force-pushed the remove-prettier-hook branch from e87e03e to 89fe586 Compare June 26, 2025 20:53
@webknjaz
webknjaz added this pull request to the merge queue Jun 26, 2025
Merged via the queue into jazzband:main with commit 9ce0376 Jun 26, 2025
39 checks passed
@sirosen
sirosen deleted the remove-prettier-hook branch November 5, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Related to maintenance processes skip-changelog Avoid listing in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants