Skip to content

🧪 Integrate actionlint @ pre-commit framework #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webknjaz merged 7 commits into from
Nov 7, 2025
Merged

🧪 Integrate actionlint @ pre-commit framework #2266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5382416
🧪 Bump Codecov action to v5
webknjaz Nov 7, 2025
71fd6f3
🧪 Bump `actions/setup-python` to v6
webknjaz Nov 7, 2025
201e4d3
🧪 Bump `actions/checkout` to v5
webknjaz Nov 7, 2025
e1d7adc
🧪 Bump `actions/cache` to v4
webknjaz Nov 7, 2025
1c502b6
🧪 Add explicit tag filter @ CI workflow trigger
webknjaz Nov 7, 2025
e46a1c1
🧪 Integrate actionlint @ pre-commit framework
webknjaz Nov 7, 2025
2a18950
📝 Add a change note for PR #2266
webknjaz Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
branches:
- main
tags:
- v*
workflow_call:
inputs:
cpython-pip-version:
Expand Down Expand Up @@ -83,11 +84,11 @@ jobs:
|| ''
}}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v5
- name: Set up Python ${{ matrix.python-version }} from GitHub
id: python-install
if: "!endsWith(matrix.python-version, '-dev')"
uses: actions/setup-python@v4
uses: actions/setup-python@v6
with:
python-version: ${{ matrix.python-version }}
- name: Set up Python ${{ matrix.python-version }} from deadsnakes
Expand All @@ -103,7 +104,7 @@ jobs:
run: |
echo "dir=$(pip cache dir)" >> $GITHUB_OUTPUT
- name: Pip cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ${{ steps.pip-cache.outputs.dir }}
key: >-
Expand Down Expand Up @@ -158,7 +159,7 @@ jobs:
- name: Upload coverage to Codecov
if: >-
!inputs.cpython-pip-version
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v5
with:
files: ./coverage.xml
flags: >-
Expand Down Expand Up @@ -190,9 +191,9 @@ jobs:
env:
TOXENV: pip${{ matrix.pip-version }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v5
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
uses: actions/setup-python@v6
with:
python-version: ${{ matrix.python-version }}
- name: Get pip cache dir
Expand All @@ -201,7 +202,7 @@ jobs:
run: |
echo "dir=$(pip cache dir)" >> $GITHUB_OUTPUT
- name: Pip cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ${{ steps.pip-cache.outputs.dir }}
key: >-
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/reusable-qa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@ jobs:
TOXENV: ${{ matrix.toxenv }}
TOX_PARALLEL_NO_SPINNER: 1
steps:
- uses: actions/checkout@main
- uses: actions/checkout@v5
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
uses: actions/setup-python@v6
with:
python-version: ${{ matrix.python-version }}
- name: Get pip cache dir
id: pip-cache
run: |
echo "dir=$(pip cache dir)" >> $GITHUB_OUTPUT
- name: Pip cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ${{ steps.pip-cache.outputs.dir }}
key: >-
Expand All @@ -45,7 +45,7 @@ jobs:
- name: Prepare cache key
id: cache-key
run: echo "sha-256=$(python -VV | sha256sum | cut -d' ' -f1)" >> $GITHUB_OUTPUT
- uses: actions/cache@v3
- uses: actions/cache@v4
with:
path: ~/.cache/pre-commit
key: pre-commit|${{ steps.cache-key.outputs.sha-256 }}|${{ hashFiles('.pre-commit-config.yaml') }}
Expand Down
7 changes: 7 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,10 @@ repos:
types_or:
- file
- symlink

- repo: https://github.com/rhysd/actionlint.git
rev: v1.7.8
hooks:
- id: actionlint

...
7 changes: 7 additions & 0 deletions changelog.d/2266.contrib.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
The linting suite now runs [`actionlint`] -- by {user}`webknjaz`.

This tool checks typical problems with GitHub Actions workflow
definitions and has a registry of widely-used GitHub Action
arguments that it validates.

[`actionlint`]: https://rhysd.github.io/actionlint/
Loading