Rename 'TestFilesCollection' dataclass to 'FileCollectionParam', fixing pytest warnings#2337
Open
sirosen wants to merge 1 commit intojazzband:mainfrom
Open
Rename 'TestFilesCollection' dataclass to 'FileCollectionParam', fixing pytest warnings#2337sirosen wants to merge 1 commit intojazzband:mainfrom
sirosen wants to merge 1 commit intojazzband:mainfrom
Conversation
`pytest` checks to see if this class can be treated as a test class under default rules because its name started with `Test`. This results in warnings in test output, and can be trivially fixed by renaming the class. `...Param` is potentially a good naming scheme for these dataclasses in general (see also jazzband#2336). It connects to `parametrize` usage well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytestchecks to see if this class can be treated as a test class underdefault rules because its name started with
Test. This results inwarnings in test output, and can be trivially fixed by renaming the
class.
...Paramis potentially a good naming scheme for these dataclasses ingeneral (see also #2336). It connects to
parametrizeusage well.As a testsuite helper class rename, this is sufficiently minor that I don't think it merits a contrib note.
(Hence, no changelog.)
Contributor checklist
Included tests for the changes.changelog.d/(seechangelog.d/README.mdfor instructions) or the PR text says "no changelog needed".
Maintainer checklist
bot:chronographer:skiplabel.(following Semantic Versioning).