-
Notifications
You must be signed in to change notification settings - Fork 332
allow managing FlexMark (markdown) plugin and options #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
allow managing FlexMark (markdown) plugin and options #788
Conversation
Need to add depenecy manually :( Added unitTest
more info https://github.com/vsch/flexmark-java/wiki/Admonition-Extension end user must add manually admonition.css (from AdmonitionExtension.getDefaultCSS()) and admonition.js (from AdmonitionExtension.getDefaultScript())
By Default use a "/img/xxxx" folder. User MUST add this folder to his WebSite
more info https://github.com/vsch/flexmark-java/wiki/Extensions#gfm-users use @xxx and not #xxx (type in documentation : see https://github.com/vsch/flexmark-java/blob/master/flexmark-ext-gfm-users/src/test/resources/gfm_users_ast_spec.md for more details)
also adding missing dependency fo gitLab Extension. commit simillar to previous but on correct branch (cherrypicking problems)
| classOwner = attributeDetails[0]; | ||
| fieldName = attributeDetails[1]; | ||
| }else { | ||
| logger.info("MarkDown option '{}', dosen't have a owner ALL holder with that attribute will be changed and may cause strange beahviors", attributeDetails.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reformat this file .... what is the info log supposed to tell the user?
"Markdown option '' does not have an ALL owner. You may experience strange behaviour as this attribute is applied in a different manner"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File Format : DONE.
For the LOG : many classes hold attributs configuration ("owner"). Without qualifier ALL Owner (if they have the exact same name for attribute) will be modified with the new value. This may cause strange behavior. If a Plugin is added (and have an attribute with the same name) will affected too.
Log replaced with "MarkDown option '{}', dosen't have a owner. ALL holder with that attribute will be modified. You may experience strange behaviour"
for issue #759
Allow management of all Flexmark Plugins.
Allow management of most flexmark Options.