Skip to content

Conversation

@jderuette
Copy link

for issue #759

Allow management of all Flexmark Plugins.
Allow management of most flexmark Options.

jderuette added 11 commits June 3, 2025 11:29
Need to add depenecy manually :(
Added unitTest
more info
https://github.com/vsch/flexmark-java/wiki/Admonition-Extension

end user must add manually admonition.css (from
AdmonitionExtension.getDefaultCSS()) and admonition.js (from
AdmonitionExtension.getDefaultScript())
By Default use a "/img/xxxx" folder. User MUST add this folder to his
WebSite
also adding missing dependency fo gitLab Extension.
commit simillar to previous but on correct branch (cherrypicking
problems)
classOwner = attributeDetails[0];
fieldName = attributeDetails[1];
}else {
logger.info("MarkDown option '{}', dosen't have a owner ALL holder with that attribute will be changed and may cause strange beahviors", attributeDetails.toString());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reformat this file .... what is the info log supposed to tell the user?
"Markdown option '' does not have an ALL owner. You may experience strange behaviour as this attribute is applied in a different manner"?

Copy link
Author

@jderuette jderuette Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File Format : DONE.
For the LOG : many classes hold attributs configuration ("owner"). Without qualifier ALL Owner (if they have the exact same name for attribute) will be modified with the new value. This may cause strange behavior. If a Plugin is added (and have an attribute with the same name) will affected too.

Log replaced with "MarkDown option '{}', dosen't have a owner. ALL holder with that attribute will be modified. You may experience strange behaviour"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants