Add impl_attrs feature
#114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guzman-raphael Thanks for your contribution! I saw your PR but am currently working on #112. I will circle back to this once that's merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #113
Depends on #112
Seeing the proposed solution in #112 inspired me to contribute to the fun in this project since it was so close to what was actually needed for our open-source project. Therefore, this is my take on a solution to #113. I've based this feature on #112 but here's a cleaner diff that you can use to follow the logic; specifically I've tried to pay extra attention to each commit to make it easier to review.
Do let me know if I've done something horribly wrong since I'm just getting started with developing procedural macros. All feedback is welcome and thanks again for the awesome lib! 🚀
P.S. I also setup a DevContainer for this project that is compatible with running locally with VSCode or Codespaces in GitHub. If there is interest, I can contribute and share that as well.