cleaned up regex function by introducing constants for patterns#143
Draft
mk2510 wants to merge 20 commits intojbesomi:masterfrom
Draft
cleaned up regex function by introducing constants for patterns#143mk2510 wants to merge 20 commits intojbesomi:masterfrom
mk2510 wants to merge 20 commits intojbesomi:masterfrom
Conversation
speeded up the default function, by writing it in just one and let it operate on strings Co-authored-by: Henri Froese <hf2000510@gmail.com>
removed the regex pattern from the functions and placed them in an constant above Co-authored-by: Henri Froese <hf2000510@gmail.com>
changed Docstring Co-authored-by: Henri Froese <hf2000510@gmail.com>
inserted the old cleaning pipeline Co-authored-by: Henri Froese <hf2000510@gmail.com>
henrifroese
requested changes
Aug 7, 2020
Collaborator
henrifroese
left a comment
henrifroese
left a comment
There was a problem hiding this comment.
Looks great overall, just a few small comments. preprocessing.py will look much nicer if this is merged.
jbesomi
reviewed
Aug 8, 2020
jbesomi
reviewed
Aug 8, 2020
Owner
|
henrifroese
approved these changes
Aug 10, 2020
Collaborator
Author
I have fixed those. The problem was just, that the series types were introduced in the file. 🤖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleaned up all regex functions and removed the new clean pipeline