Skip to content

Conversation

@jbohnslav
Copy link
Owner

@jbohnslav jbohnslav commented Jan 12, 2025

PR: Code Quality Improvements and Development Infrastructure Updates

Major Changes

  1. Development Infrastructure

    • Added GitHub Actions workflows for CI/CD:
      • Main workflow for testing
      • GPU-specific workflow
      • Pre-commit checks
    • Introduced pre-commit hooks with Ruff linting
    • Added CODEOWNERS file for code review management
    • Added pytest configuration and new test infrastructure
  2. Dependency Management

    • Migrated to requirements.txt for version management
    • Updated Docker configurations
    • Added setup tests script
  3. Code Quality

    • Implemented Ruff linting across the codebase
    • Removed deprecated comments and cleaned up code
    • Fixed various linting issues across multiple modules
    • Improved test coverage and reliability
  4. Technical Improvements

    • Changed default stride to 1
    • Added length saving functionality
    • Fixed test suite and added download script
    • Documentation updates across multiple files

Documentation Updates

  • Added new testing documentation
  • Updated installation guides
  • Enhanced Docker usage documentation
  • Improved getting started guide
  • Updated performance documentation

Impact

These changes significantly improve the project's maintainability, development workflow, and code quality while ensuring better testing coverage and continuous integration practices.

Testing

  • All tests are passing
  • New test infrastructure has been added
  • Integration tests have been updated and fixed

@jbohnslav jbohnslav self-assigned this Jan 12, 2025
@jbohnslav jbohnslav requested a review from Copilot January 12, 2025 05:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 111 out of 117 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • .style.yapf: Language not supported
  • CODEOWNERS: Language not supported
  • README.md: Evaluated as low risk
  • deepethogram/init.py: Evaluated as low risk
  • deepethogram/main.py: Evaluated as low risk
  • deepethogram/callbacks.py: Evaluated as low risk

@jbohnslav jbohnslav merged commit a77c77c into master Jan 12, 2025
4 checks passed
@jbohnslav jbohnslav deleted the jbohnslav/202408_fix branch January 12, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants