Skip to content

Conversation

@jmfinelli
Copy link
Contributor

To use workflow_dispatch more intuitively

No test needed

@tomjenkinson
Copy link
Member

IMO I find the current way of listing them first more intuitive. I can approve the pull request as I don't feel so strongly about it but I like how they are now. Please can I ask for a bit of insight as to your thoughts on why it is more intuitive to add them last?

@jmfinelli
Copy link
Contributor Author

pull_request_repo and pull_request_ref are not used very often when actions are triggered manually. Having them as the first two fields of the list is counterintuitive IMO.

Copy link
Member

@tomjenkinson tomjenkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still prefer at the top but it's OK for me for them to move so approving

@jmfinelli
Copy link
Contributor Author

@mmusgrov, do you mind having a look at this PR? It is a small change but I don't want to impose my point of view to the team so I was wondering if you think that moving those fields from the top to the bottom could be an improvement or not. Thanks!

@marcosgopen
Copy link
Member

I don't have a strong preference about the proposed change, as there is no functional change I am approving.

Copy link
Member

@mmusgrov mmusgrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good

@jmfinelli jmfinelli force-pushed the reorder_inputs_workflow_dispatch branch from fe893a8 to 7bdb342 Compare January 16, 2026 12:17
@jmfinelli jmfinelli force-pushed the reorder_inputs_workflow_dispatch branch from 7bdb342 to 3501530 Compare January 16, 2026 12:23
@jmfinelli jmfinelli merged commit aa9e60e into jbosstm:main Jan 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants