remove sqlx runtime features from the library #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the cargo book ([source](https://doc.rust-lang.org/cargo/reference/features.html#feature-unification)): > When a dependency is used by multiple packages, Cargo will use the union of all features enabled on that dependency when building it. This helps ensure that only a single copy of the dependency is used. See the features section of the resolver documentation for more details. So, the library should not force a sqlx runtime to the end-user. The library should let the user decide which runtime to enable and cargo will unified the features by itself.
|
+1 on this PR. Also +1 on the idea to move to a v0.5 and update crates.io since the current v0.4 release depends on outdated sqlx version 0.5.13. |
|
Any chance to merge this pull request and publish it on crates.io? This would be really helpful. |
|
FYI - as a workaround, you can use However, I still think this PR deserve to be merged to avoid any confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the cargo book (source):
So, the library should actually not force a sqlx runtime to the end-user. The library should let the user decide which runtime to enable and cargo will unify everything by itself.
This is obviously not backward compatible with the current release so I guess a
0.5.0might be required. I just not sure if I should include the bump of version in my PR :)