Skip to content

[WIP] Refactor geonav-sim into strapdown-sim using feature flag#213

Merged
jbrodovsky merged 1 commit into
mainfrom
copilot/sub-pr-212
Jan 8, 2026
Merged

[WIP] Refactor geonav-sim into strapdown-sim using feature flag#213
jbrodovsky merged 1 commit into
mainfrom
copilot/sub-pr-212

Conversation

Copilot AI commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

Plan: Address Review Comments from PR #212

  • Fix wildcard pattern in convert_resolution_gravity() (line 736)

    • Explicitly match all GeoResolution variants
    • Log warning for unsupported resolutions (ThirtySeconds, FifteenSeconds, ThreeSeconds, OneSecond)
    • Map unsupported resolutions to OneMinute (closest supported)
  • Fix wildcard pattern in convert_resolution_magnetic() (line 754)

    • Explicitly match all GeoResolution variants
    • Log warning for unsupported resolutions (OneMinute, ThirtySeconds, FifteenSeconds, ThreeSeconds, OneSecond)
    • Map unsupported resolutions to TwoMinutes (closest supported)
  • Address unused process_files() function in common.rs

    • Add #[allow(dead_code)] attribute to suppress warnings
    • Add doc comment explaining it's for future use
  • Test the changes

    • Build with and without geonav feature
    • Verify warnings are properly logged
    • Run clippy and rustfmt
  • Final review and completion


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI requested a review from jbrodovsky January 8, 2026 19:18
Base automatically changed from refactor to main January 8, 2026 23:04
@jbrodovsky
jbrodovsky marked this pull request as ready for review January 8, 2026 23:04
Copilot AI review requested due to automatic review settings January 8, 2026 23:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@jbrodovsky
jbrodovsky merged commit 0f09fe8 into main Jan 8, 2026
1 check failed
@jbrodovsky
jbrodovsky deleted the copilot/sub-pr-212 branch January 8, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants