Resolve clippy type_complexity warnings in geophysical config prompts#219
Merged
Conversation
Co-authored-by: jbrodovsky <57160841+jbrodovsky@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Simplify geophysical config prompting functions
Resolve clippy type_complexity warnings in geophysical config prompts
Jan 9, 2026
jbrodovsky
marked this pull request as ready for review
January 9, 2026 19:36
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves clippy type_complexity warnings by introducing a type alias for complex tuple return types in geophysical configuration prompt functions.
- Adds
GeoMeasurementConfigtype alias to simplify function signatures - Updates
prompt_gravity_config()andprompt_magnetic_config()to use the new type alias - Includes comprehensive documentation explaining each tuple field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clippy flagged the return types of
prompt_gravity_config()andprompt_magnetic_config()as excessively complex:Option<(GeoResolution, Option<f64>, Option<f64>, Option<String>)>.Changes
GeoMeasurementConfigtype alias to represent the tuple structureThe type alias is a zero-cost abstraction that preserves existing tuple destructuring patterns in calling code.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.