Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major refactor #41

Closed
wants to merge 3 commits into from
Closed

Conversation

justinmchase
Copy link

@justinmchase justinmchase commented Aug 10, 2018

I've tried to use this library a few times but it seems to be failing due to a few simple nodejs related issues. I hope this isn't taken the wrong way but I fixed it up!

What this fixes:

  • Browser compatible
  • Fixes the import token bug, which made it unusable as a dependency
  • Adds build / watch / lint
  • Fixes the lodash issue
  • Added gulp 4, some basic tasks
  • Updated babel and moved to env preset
  • Libraries cannot use babel-register except during tests
  • Cleaned up what gets included in the package
  • Added standard linter
  • Updated some syntax to es6, e.g. import, const, map, reduce, etc.
  • Fixed an unreported bug in the giant unicode regexp
  • Removed inconsistent, incorrectly patterned callback style from synchronous functions

I would recommend a Major version bump for this!

@justinmchase
Copy link
Author

Fixes #40 #39 #37 #36 #31 #24 #12

@fungilation
Copy link
Contributor

"Major" is right ^.^

Looks good, at a glance.

@CraigHarley
Copy link
Collaborator

Code looks good to me, I haven't tested it though.

@justinmchase
Copy link
Author

Closing since no traction for a while.

@xpipko
Copy link

xpipko commented Dec 28, 2018

Code looks good, made similar changes before seeing this merge request, specifically the babel-env updates to work with browserify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants