Magnetic deviation + Airframe updates #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbud
reviewed
Apr 29, 2024
There was a problem hiding this comment.
It looks like this may need to be updated to async functions based on the way it pulls from jsons, also part of the calculation is in old school js, for continuity I request we avoid 'var' and 'require' and stick with TS imports and let or const for variable declarations.
I haven't had a moment to test everything yet, great work on this, thank you. I will check back in a couple days when I have the free time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added magnetic deviation calculation using https://github.com/naturalatlas/geomagnetism
Also updated aircraft profiles from different PR
and fixed github actions build