Upgrade jcabi parent to 1.44.0 and refresh dependencies#60
Closed
bibonix wants to merge 1 commit intojcabi:masterfrom
Closed
Upgrade jcabi parent to 1.44.0 and refresh dependencies#60bibonix wants to merge 1 commit intojcabi:masterfrom
bibonix wants to merge 1 commit intojcabi:masterfrom
Conversation
- Bump parent jcabi to 1.44.0 (was 1.38.0) - Bump commons-lang3 to 3.20.0 (was 3.13.0) - Bump lombok to 1.18.46 (was 1.18.36) - Replace StringUtils.equalsIgnoreCase deprecated in commons-lang3 3.20 with String#equalsIgnoreCase to keep the build warning-free under -Werror
Author
|
Closing as redundant — master already contains these exact upgrades via #59. Will pivot to other improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refreshes the project to the latest stable artifacts the
jcabiparent already exposes:com.jcabi:jcabi(parent POM)org.apache.commons:commons-lang3org.projectlombok:lombokjcabi-aspectswas already at 0.26.0, the latest release.Code change
commons-lang33.20 deprecates the staticStringUtils.equalsIgnoreCase(CharSequence, CharSequence). The singlecall site in
URN#validatewas switched to plainString#equalsIgnoreCase, sinceURN.PREFIXandnidare bothString. Without this change the new deprecation warning would failthe build under the
-Werrorcompiler flag set by the parent.Verification
Notes about
qulice 0.26.0I attempted to bump the linter to
0.26.0(the parent stays on0.25.1) but that release ships two new checks that would eachrequire an architectural rewrite rather than a code clean-up:
ConstructorsCodeFreeCheckrejects every method call inside aconstructor (regex
text.matches(...),String.format(...),URN.encode(...)and the privatevalidate()helper), whichforces the validation/normalisation logic out of every public
URN(...)constructor. Since these constructors are part of thepublic API and validation can't be deferred without a behavioural
change, this is left out of scope.
QualifyInnerClassCheckadds the root class itself to its"nested" set, so any
new URN(...)insideURN.java(e.g. thestatic factory
URN.create) is reported. This looks like a bug inthe check rather than a code smell to fix here.
The local
qulice-maven-pluginversion override was therefore left at0.25.1, which matches what the upgraded parent provides anyway.