This repository was archived by the owner on Dec 6, 2025. It is now read-only.
Make docker build the project for contributors#27
Open
asztrikx wants to merge 1 commit intojckleiner:masterfrom
Open
Make docker build the project for contributors#27asztrikx wants to merge 1 commit intojckleiner:masterfrom
asztrikx wants to merge 1 commit intojckleiner:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current process requires contributors to have the build system configured on their system. This change helped me to contribute to this project while not having mvn installed.
The new base image already has maven and jdk 11 installed. The project is copied into the container's build folder, then its output jar is moved to the conventional /app path.