add from/to, fix $speed, rm $temp #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug: the logic for parsing $speed was backwards. bug: temp file not removed on exit enhancement: added -f and -t options to extract short clips from a long video
STRML
reviewed
Jan 19, 2017
| speed=1 | ||
| fi | ||
|
|
||
| if [ ! -z "$to" ]; then |
There was a problem hiding this comment.
You'll need to add the to= and from= vars, otherwise you'll get:
/usr/local/bin/gifify: line 104: to: unbound variable
/usr/local/bin/gifify: line 104: temp: unbound variable
jclem
requested changes
Jan 19, 2017
| speed=1 | ||
| fi | ||
|
|
||
| if [ ! -z "$to" ]; then |
| @@ -16,12 +17,24 @@ function printHelpAndExit { | |||
| echo ' below approximately 60.' | |||
| echo ' p SCALE: Rescale the output, e.g. 320:240' | |||
| echo ' x: Remove the original file and resulting .gif once the script is complete' | |||
| echo ' f from: The start time of the clip, in seconds' | |||
| echo ' t to: The end time of the clip, in seconds' | |||
There was a problem hiding this comment.
These should be formatted as f FROM and t TO to indicate flags vs values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: the logic for parsing $speed was backwards.
bug: temp file not removed on exit
enhancement: added -f and -t options to extract short clips from a long video