Improve binary detection and broaden test coverage#13
Merged
Conversation
jcouture
commented
Apr 9, 2026
jcouture
commented
Owner
- add MIME-based binary detection via gofile and wire BinaryCheck through discovery
- expand default excludes to cover nested .git directories
- add PDF fixture and extensive coverage tests across app, filesystem, detector, finding, and report layers
- update dependencies including gofile and golang.org/x/sys
- add gofile-based BinaryCheck to classify binary magic headers - propagate binary check through discovery and eligibility reasons - exclude .git directories with recursive pattern default - add pdf fixture and broaden coverage across app, filesystem, detector, finding, report - bump dependencies including gofile and golang.org/x/sys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.