Skip to content

Fix AICC identifier regex #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix AICC identifier regex #979

wants to merge 1 commit into from
+11 −1

Conversation

jcputney
Copy link
Owner

Summary

  • correct AICC CMIIdentifier pattern to allow periods and hyphens
  • test that dashes and periods are accepted in cmi.core.student_id

Testing

  • npm test

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 97.28% 8964 / 9214
🔵 Statements 97.28% 8964 / 9214
🔵 Functions 98.31% 818 / 832
🔵 Branches 94.12% 2130 / 2263
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/constants/regex.ts 100% 100% 100% 100%
Generated in workflow #419 for commit 12f99a6 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcputney