Skip to content

Fix UnsetType truthiness narrowing in type stubs #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
overlorde wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Fix UnsetType truthiness narrowing in type stubs #975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/msgspec/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ T = TypeVar("T")

class UnsetType(enum.Enum):
UNSET = "UNSET"
def __bool__(self) -> Literal[False]: ...

UNSET = UnsetType.UNSET

Expand Down
5 changes: 5 additions & 0 deletions tests/typing/basic_typing_examples.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ def check_unset_type_lowering(x: int | msgspec.UnsetType) -> None:
reveal_type(x) # assert "unset" not in typ.lower()


def check_unset_type_truthiness_lowering(x: str | msgspec.UnsetType) -> None:
if x:
reveal_type(x) # assert "unset" not in typ.lower()


def check_nodefault() -> None:
reveal_type(msgspec.NODEFAULT) # assert "Any" not in typ
str(msgspec.NODEFAULT)
Expand Down
Loading