Implement quantization for Decimal type when encode#978
Open
NyanFisher wants to merge 1 commit intojcrist:mainfrom
Open
Implement quantization for Decimal type when encode#978NyanFisher wants to merge 1 commit intojcrist:mainfrom
NyanFisher wants to merge 1 commit intojcrist:mainfrom
Conversation
2357ed5 to
076b58c
Compare
2ee9741 to
31effee
Compare
c0b10e1 to
117001b
Compare
117001b to
b5ff6b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Description of the problem solved by this PR
The msgspec library has many useful features, but the current version lacks the ability to correctly quantize Decimal values during encoding. In applications related to finance and precise calculations, it is critical to take into account maximum accuracy and return values rounded to a specified precision. Without implementing this functionality, a complete transition from pydantic to msgspec is not possible.
Changes implemented in this PR
This improvement enhances the functionality of the library and ensures full compatibility when transitioning to msgspec in financial and other applications that require precise control over the representation of decimal numbers.
Examples
decimal_quantize
decimal_rounding
I would appreciate any comments on improving or restructuring the code, as I don't often write in C.
Fix my issue - #848