Fix broken menu items in the Extensions -> OSARA menu on Mac. #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #1180, OSARA started registering all commands shortly after startup instead of immediately on startup. This was done to enable interception of SWS commands. Unfortunately, this broke items in the OSARA menu on Mac. Presumably, the menu hook gets called slightly earlier on Mac, before our commands get registered, and so our menu items can't be associated with the correct command. To fix this, we now register OSARA's commands immediately on startup, but we continue to register other commands that we want to intercept slightly later. Developers should note that OSARA's own commands are now listed in the OSARA_COMMANDS array, not the COMMANDS array.
Owner
Author
|
I haven't actually tested this yet on Mac. If someone is able to do that with the build that should arrive here in a few minutes, I'd be grateful. |
Contributor
|
Thanks for at build so fast. I'll check it out tonight. Sendt fra min iPhone via Braille Sense U2/MBrailleDen 24. mar. 2025 kl. 06.42 skrev James Teh ***@***.***>:
I haven't actually tested this yet on Mac. If someone is able to do that with the build that should arrive here in a few minutes, I'd be grateful.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
jcsteh left a comment (jcsteh/osara#1219)
I haven't actually tested this yet on Mac. If someone is able to do that with the build that should arrive here in a few minutes, I'd be grateful.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Contributor
|
Nice. All Osara menu items trigger just as they are supposed to here. Cheers! |
|
Same results as @jennykbrennan says. NICE work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1180, OSARA started registering all commands shortly after startup instead of immediately on startup. This was done to enable interception of SWS commands. Unfortunately, this broke items in the OSARA menu on Mac. Presumably, the menu hook gets called slightly earlier on Mac, before our commands get registered, and so our menu items can't be associated with the correct command. To fix this, we now register OSARA's commands immediately on startup, but we continue to register other commands that we want to intercept slightly later. Developers should note that OSARA's own commands are now listed in the OSARA_COMMANDS array, not the COMMANDS array.
Fixes #1218.