Keep osara preset list open#1323
Conversation
…el button to Close
… to browse and audition filter results
… can be loaded with a mouse click, add access key for Filter
|
I goofed case sensitivity in the last PR, got confused, probably deleted the wrong thing, was easier to start a new PR. Sorry! This one has an Apply button and some extra access keys. I've added a label to the list box as well, might help with identifying it so Control+Space could work, haven't looked into that yet though. |
|
I'd still like to get your thoughts on this comment I made on the other PR:
You've added the Apply button now, but enter activates that and there's no OK button, so the muscle memory breakage still applies. Unless you don't think that's a problem in real usage? |
readme.md
Outdated
| The Filter field allows you to filter the list to show only presets containing the entered text. | ||
| Pressing the OK button activates the preset that's currently selected in the list. | ||
| The Filter field (Alt+F) allows you to filter the list to show only presets containing the entered text. | ||
| Pressing Enter while focus is in the list box or Alt+A to click the Apply button loads the selected preset. |
There was a problem hiding this comment.
Can we say "activate the Apply button"? I'm not a fan of using a mouse specific term like "click" for keyboard users. :) I'll grant this is pedantry, though. Same on the line below.
|
I'm pretty sure the gain is worth the pain. Before this, the filter feature was only useful for viewing preset names, now it's useful for hearing them in context too. Pretty big win with only minimal muscle memory disruption IMO. |
|
Thoughts on the alternative of having both Apply and OK? Enter to apply and dismiss, alt+a to just apply. That's a pretty common pattern. |
|
I really like being able to have one hand on arrows and reach Enter from there, it's a wicked improvement when you're playing an instrument with one hand and testing filtered results with the other. Can we try it how it is now? I'll implement your suggestion if muscle memory breakage hits harder than I thought. |
|
I can't figure out how to get play/pause working. Might have to go without that nicety unless you've got ideas (ideally ideas that are simple enough for me to try lol) |
jcsteh
left a comment
jcsteh
left a comment
There was a problem hiding this comment.
Fair enough.
Supporting control+space is going to be annoying and I don't have the headspace to faf with it right now. I don't think we need to block on that though.
readme.md
Outdated
| To cancel a note preview, press the Control key. | ||
|
|
||
| ### Navigating FX Presets Without Activating Them (Windows Only) | ||
| ### Searching and navigating FX Presets Without Activating Them (Windows Only) |
There was a problem hiding this comment.
nit: Navigating should have a capital n, since we're using title case in the rest of this heading.
| ID_FX_PRESET_DLG DIALOGEX 250, 125, 200, 350 | ||
| CAPTION "FX Preset" | ||
| BEGIN | ||
| LTEXT "&Presets:", IDC_STATIC, 10, 0, 40, 10 |
There was a problem hiding this comment.
Note that even if we support control+space eventually, we wouldn't use this label because it's localised. I don't mind whether we keep this or not, but I thought I'd flag this in case it's the only reason you added the label here.
|
It's probably worth filing an issue to support control+space here so we don't forget. |
2 participants
No description provided.