Skip to content

Fix broken VST2 support when introducing VST3 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brummbrum wants to merge 7 commits into from
Closed

Fix broken VST2 support when introducing VST3 #36

brummbrum wants to merge 7 commits into from

Conversation

@brummbrum
Copy link
Contributor

@brummbrum brummbrum commented Apr 29, 2022

No description provided.

brummbrum and others added 7 commits April 28, 2022 22:49
@brummbrum
Merge pull request #56 from jcsteh/vst3
00a5bbd 
Support the VST3 version of Komplete Kontrol.
@brummbrum
bug fix
7955bae 
VST3 pull request broke VST2 support - fixed
@brummbrum
Update niMidi.cpp
982ec8c
@brummbrum
Merge pull request #57 from brummbrum/ini_FileOperations
a004da8 
Update niMidi.cpp
@chigkim
changed wdl master branch to main
2aeae49
@brummbrum
Merge pull request #59 from chigkim/master
837bfda 
Cmake: changed wdl master branch to main (Justin changed branch tag)
@brummbrum
Update instructions for ARM based Mac
3a328c8
@jcsteh
Copy link
Owner

jcsteh commented Jun 6, 2025

I figured out what was breaking this. The full name of the effect is:
VST3i: Komplete Kontrol (Native Instruments) (32 out)
That meant that we were getting a space after "Kontrol", not a null character. I've rewritten that prefix code now so it's cleaner and doesn't suffer from this problem.

@jcsteh jcsteh closed this Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brummbrum @jcsteh @chigkim