cicd: add cicd for cuda device. #623
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuZhang99
force-pushed
the
dev/cuda_ci
branch
from
9bd80b2 to
66701ab
Compare
XuZhang99
requested review from
DongheJin,
JimHsiung and
walsonyang
as code owners
XuZhang99
force-pushed
the
dev/cuda_ci
branch
4 times, most recently
from
35f3ce7 to
c304788
Compare
Collaborator
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a CI/CD script for CUDA devices, cibuild/build_cuda.sh, and removes several now-unused installation scripts, likely because their functionality has been moved into the Docker build process. The changes are mostly good, but I have identified a critical security issue and a potential bug in the new build_cuda.sh script. My main concerns are the use of the --privileged Docker flag, which should be replaced with the more secure --gpus flag, and an unquoted path that could cause issues with certain directory names. Please see my detailed comments below.
…line build process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.