-
Notifications
You must be signed in to change notification settings - Fork 113
feat: support auto-selection and pre-check for function call and reasoning paser. #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable feature for automatically selecting function call and reasoning parsers based on the model type, which improves usability. The implementation also includes pre-checks for parser support. The changes are mostly in the parser logic and flag handling.
My review identifies a critical issue that could lead to a crash, along with several high-severity issues related to maintainability and code consistency. I've provided suggestions to address these points, including using more robust and extensible patterns for factory functions and error message generation.
36b2835 to
ed2fb9f
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces an excellent feature for auto-selecting and pre-checking function call and reasoning parsers based on the model type, which significantly improves usability and robustness. The refactoring to use factory maps for creating detectors is a great enhancement for code maintainability. I've identified a high-severity bug in the error message generation for the reasoning parser, which could lead to user confusion, and have provided a detailed comment with a suggested fix.
ed2fb9f to
ee3f9c0
Compare
No description provided.