Skip to content

Conversation

@RobbieLeung
Copy link
Collaborator

@RobbieLeung RobbieLeung commented Jan 6, 2026

No description provided.

@RobbieLeung RobbieLeung requested a review from yingxudeng January 6, 2026 07:23
@RobbieLeung RobbieLeung changed the title feat: support auto-selection and pre-check for function call and reas… feat: support auto-selection and pre-check for function call and reasoning paser. Jan 6, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable feature for automatically selecting function call and reasoning parsers based on the model type, which improves usability. The implementation also includes pre-checks for parser support. The changes are mostly in the parser logic and flag handling.

My review identifies a critical issue that could lead to a crash, along with several high-severity issues related to maintainability and code consistency. I've provided suggestions to address these points, including using more robust and extensible patterns for factory functions and error message generation.

@RobbieLeung
Copy link
Collaborator Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an excellent feature for auto-selecting and pre-checking function call and reasoning parsers based on the model type, which significantly improves usability and robustness. The refactoring to use factory maps for creating detectors is a great enhancement for code maintainability. I've identified a high-severity bug in the error message generation for the reasoning parser, which could lead to user confusion, and have provided a detailed comment with a suggested fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants