Skip to content

bugfix: fix DeepSeek failing to run when enabling DP. #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DongheJin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix: fix DeepSeek failing to run when enabling DP. #684

DongheJin wants to merge 1 commit into from
+6 −2

Conversation

@DongheJin
Copy link
Collaborator

@DongheJin DongheJin commented Jan 9, 2026

No description provided.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 9, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an issue with DeepSeek models when data parallelism (DP) is enabled. The changes involve mapping CHUNKED_PREFILL to PREFILL forward type in the engine and updating a log message for clarity. While the fix for forward type mapping is in the right direction, the logic for determining the unified forward type across DP ranks is not robust and could lead to inconsistencies. I've provided a critical suggestion to add a consistency check to prevent potential crashes or silent errors in a distributed environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuZhang99 XuZhang99 XuZhang99 approved these changes

@yq33victor yq33victor Awaiting requested review from yq33victor yq33victor is a code owner

@liutongxuan liutongxuan Awaiting requested review from liutongxuan liutongxuan is a code owner

@walsonyang walsonyang Awaiting requested review from walsonyang walsonyang is a code owner

@RobbieLeung RobbieLeung Awaiting requested review from RobbieLeung RobbieLeung is a code owner

@JimHsiung JimHsiung Awaiting requested review from JimHsiung JimHsiung is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DongheJin @XuZhang99