Skip to content

Add GitHub Actions workflow #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add GitHub Actions workflow #32

wants to merge 1 commit into from

Conversation

@marvinschopf
Copy link

@marvinschopf marvinschopf commented Mar 17, 2021

Hello @jdah!

I have added a small GitHub Actions CI workflow.

Kind regards
Marvin

@mathisve
Copy link

mathisve commented Mar 20, 2021

Looks good to me!

Daniellop1
Daniellop1 approved these changes Mar 31, 2021
View reviewed changes
Copy link

@Daniellop1 Daniellop1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Tiebe
Copy link

Tiebe commented Apr 19, 2021

Shouldn't you run make libs as well?

@mathisve
Copy link

mathisve commented Apr 19, 2021

That shouldn't be an issue @Tiebe.
When running the workflow in nektos act, it automatically does make libs.
The only thing I had to change was add sudo apt-get update && sudo apt-get install make cmake clang.
But I'm guessing that's just a side-effect of nektos act itself.

@Tiebe
Copy link

Tiebe commented Apr 20, 2021

Ah alright!

DamieFC
DamieFC approved these changes Apr 23, 2021
View reviewed changes
Copy link

@DamieFC DamieFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good!

ghost
ghost approved these changes Apr 24, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

xAffan
xAffan approved these changes Jun 3, 2021
View reviewed changes
Copy link

@xAffan xAffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is good⚠️™

@MarcelCoding
Copy link

MarcelCoding commented Jul 29, 2021

How about uploading the binary as an artifact? https://github.com/actions/upload-artifact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers

@mathisve mathisve mathisve approved these changes

@Daniellop1 Daniellop1 Daniellop1 approved these changes

@xAffan xAffan xAffan approved these changes

@DamieFC DamieFC DamieFC approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@marvinschopf @mathisve @Tiebe @MarcelCoding @Daniellop1 @xAffan @DamieFC