update allocated message buffer size to avoid hardcoded number.#10
Open
bovine wants to merge 1 commit intojdc8:masterfrom
Open
update allocated message buffer size to avoid hardcoded number.#10bovine wants to merge 1 commit intojdc8:masterfrom
bovine wants to merge 1 commit intojdc8:masterfrom
Conversation
Author
|
It was actually increased from 32 bytes to 40, then 48, then 64 over several different commits over the years. It was 32 bytes here: zeromq/libzmq@7bf516d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The size of zmq_msg_t was increased from 32 bytes to 64 bytes in v4.2.0-rc1 about 2.5 years ago:
zeromq/libzmq@9019403
Failure to allocate a large enough buffer causes memory corruption and typically ckfree() faults when trying to close the message.