-
Notifications
You must be signed in to change notification settings - Fork 27
feat: support MAX_DBCONN_RETRY_TIMES #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
codingjoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there! I somehow had notifications on for this repo and found myself reviewing your PR before noticing. I hope you don't mind my comments. Generally, I'd advise adding some lines of documentation. Otherwise, people won't know about this setting. Maybe consider writing a test as well, to validate the new behavior works as expected. Best Joe!
96bab13 to
eed4f8d
Compare
eed4f8d to
2ac83bd
Compare
Thank you for your advice. I've add settings description in |
|
😴 |
|
Hi @jdelic, I got pinged about this on LinkedIn. Though I only got involved per accident, please don't hesitate to ask for help :) Best, Joe |
|
@jdelic Can web merge this? |
|
This has been released in v0.1.9. Thank you for your incredible patience and to @rajasimon for relentlessly pushing. |
Thank you for the package!
The dbconn_retry give up retry after retry once. Howerver, we found that sometimes retry more times could help!
This PR support to set
MAX_DBCONN_RETRY_TIMESindjango.conf, which is default to be1Best Wishes