Skip to content

Conversation

@zhangzhw8
Copy link
Contributor

Thank you for the package!
The dbconn_retry give up retry after retry once. Howerver, we found that sometimes retry more times could help!
This PR support to set MAX_DBCONN_RETRY_TIMES in django.conf, which is default to be 1

Best Wishes

Copy link

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! I somehow had notifications on for this repo and found myself reviewing your PR before noticing. I hope you don't mind my comments. Generally, I'd advise adding some lines of documentation. Otherwise, people won't know about this setting. Maybe consider writing a test as well, to validate the new behavior works as expected. Best Joe!

@zhangzhw8 zhangzhw8 force-pushed the feat_support_retry_times branch 2 times, most recently from 96bab13 to eed4f8d Compare April 12, 2022 07:30
@zhangzhw8 zhangzhw8 force-pushed the feat_support_retry_times branch from eed4f8d to 2ac83bd Compare April 12, 2022 07:32
@zhangzhw8
Copy link
Contributor Author

Hi there! I somehow had notifications on for this repo and found myself reviewing your PR before noticing. I hope you don't mind my comments. Generally, I'd advise adding some lines of documentation. Otherwise, people won't know about this setting. Maybe consider writing a test as well, to validate the new behavior works as expected. Best Joe!

Thank you for your advice. I've add settings description in README.rst and improve the test case. Please re-review.

@vrnvorona
Copy link

😴

@codingjoe
Copy link

Hi @jdelic,

I got pinged about this on LinkedIn. Though I only got involved per accident, please don't hesitate to ask for help :)

Best, Joe

@rajasimon
Copy link

@jdelic Can web merge this?

@coveralls
Copy link

coveralls commented Jul 11, 2025

Coverage Status

coverage: 96.992% (+0.1%) from 96.875%
when pulling 6c8b824 on zhangzhw8:feat_support_retry_times
into 91244a5 on jdelic:master.

@jdelic jdelic merged commit fdd8595 into jdelic:master Jul 11, 2025
4 checks passed
@jdelic
Copy link
Owner

jdelic commented Jul 11, 2025

This has been released in v0.1.9. Thank you for your incredible patience and to @rajasimon for relentlessly pushing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants